Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c++20 to enums #3905

Merged
merged 4 commits into from
Jul 15, 2019
Merged

Add c++20 to enums #3905

merged 4 commits into from
Jul 15, 2019

Conversation

Jasdriel
Copy link
Contributor

@Jasdriel Jasdriel commented Jul 9, 2019

This are the files in the Typescript part that I found to add the enums, is ok with this changes or there are other parts to update?

For issue #3448.

Copy link
Collaborator

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my other comment

@michelleangela
Copy link
Contributor

michelleangela commented Jul 9, 2019

Also add "c++20" as another <option> to Config UI in settings.html

And to package.json

@sean-mcmanus
Copy link
Collaborator

The msvc version needs to be changed in the .json files: https://github.com/microsoft/vscode-cpptools/blob/master/Extension/bin/msvc.32.intel.json and the other 2 .msvc files.

@sean-mcmanus
Copy link
Collaborator

Okay, this seems good, but don't check it in until the C++ side is checked in.

@michelleangela
Copy link
Contributor

michelleangela commented Jul 9, 2019

Also need to add c++20 to the API https://github.com/microsoft/vscode-cpptools-api. You'll have to create separate pull request on that repo.

@Jasdriel Jasdriel marked this pull request as ready for review July 12, 2019 17:15
@Jasdriel Jasdriel merged commit 3faaca1 into master Jul 15, 2019
@bobbrow bobbrow deleted the joreyesp/addNewEnumsCpp branch August 8, 2019 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants