Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update c_cpp_properties.json description in Config UI and documentation #3872

Merged
merged 16 commits into from
Jul 8, 2019
Merged

Update c_cpp_properties.json description in Config UI and documentation #3872

merged 16 commits into from
Jul 8, 2019

Conversation

michelleangela
Copy link
Contributor

@michelleangela michelleangela commented Jul 3, 2019 •
edited
Loading

Updated the descriptions of settings in c_cpp_properties.json in Config UI and documentation file. Note that some descriptions are worded differently on Config UI as it applies to the UI instead of json file.

Config UI

  • Added some description from documentation.

Documentation

  • Added missing settings and its descriptions.
  • Updated descriptions of some settings.
  • Note: c_cpp_properties.json.md is only getting updated to use as reference for the new documentation.

Also updated FAQ to reflect new IntelliSense cache location.

@michelleangela michelleangela requested review from a team and bobbrow July 3, 2019 18:51
@michelleangela
Copy link
Contributor Author

Should I also update ~\Extension\c_cpp_properties.schema.json or leave it as is?

sean-mcmanus
sean-mcmanus requested changes Jul 5, 2019
View reviewed changes
Copy link
Collaborator

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The" shouldn't be capitalized.

@michelleangela
Copy link
Contributor Author

"The" shouldn't be capitalized.

Fixed.

@sean-mcmanus sean-mcmanus self-requested a review July 5, 2019 23:40
@michelleangela michelleangela merged commit 53107bc into master Jul 8, 2019
@michelleangela michelleangela deleted the mimatias/update-doc branch July 9, 2019 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bobbrow bobbrow bobbrow left review comments

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michelleangela @bobbrow @sean-mcmanus