Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use greater than as Playwright requirement #3

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Aug 4, 2020

Drive by: Use better README test example names.

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Pull Request Test Coverage Report for Build 195325539

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.714%

Totals Coverage Status
Change from base Build 193801041: 0.0%
Covered Lines: 78
Relevant Lines: 91

💛 - Coveralls

@mxschmitt
Copy link
Member Author

Seems to work, confirmed via GitHub Actions logs.

Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G doesn't like to be scraped, can we get a more neutral example site?

@mxschmitt mxschmitt force-pushed the bugfix/use-recent-playwright-version branch from 0ae71f2 to 87ba806 Compare August 5, 2020 14:18
@mxschmitt mxschmitt merged commit 61ad69e into main Aug 5, 2020
@mxschmitt mxschmitt deleted the bugfix/use-recent-playwright-version branch August 15, 2020 07:48
@coveralls
Copy link

coveralls commented Apr 1, 2024

Pull Request Test Coverage Report for Build 195325539

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.714%

Totals Coverage Status
Change from base Build 193801041: 0.0%
Covered Lines: 78
Relevant Lines: 91

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants