Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConPTY Support #236

Merged
merged 56 commits into from
Dec 21, 2018
Merged

ConPTY Support #236

merged 56 commits into from
Dec 21, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 19, 2018

This introduces ConPTY support to node-pty which will be used when the Windows version is >=17692, there will also be a setting to allow consumers to say which to use.

Fixes #7
Fixes #168
Fixes #216

TODO

@Tyriar
Copy link
Member Author

Tyriar commented Dec 21, 2018

@Eugeny also be warned the PR isn't complete just yet, the terminal's aren't cleaned up after they exit and no event is fired for example.

@Astrantia
Copy link

@Tyriar Is this ready to be used in Code Insiders?

@Tyriar
Copy link
Member Author

Tyriar commented Dec 21, 2018

@Astrantia very soon 😃

@Tyriar
Copy link
Member Author

Tyriar commented Dec 21, 2018

Let's do this 🚀 💥 😱 🏗 🏎 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants