Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 People Picker: Adding Customization support for Persona Chip #653

Merged
merged 3 commits into from
May 12, 2024
Merged

v2 People Picker: Adding Customization support for Persona Chip #653

merged 3 commits into from
May 12, 2024

Conversation

Anubhvv
Copy link
Collaborator

@Anubhvv Anubhvv commented May 11, 2024 •
edited
Loading

Problem

There wasn't an option for modifying the Personal Chip Tokens which is used by People Picker

Root cause

By design

Fix

Exposing the param

Validations

(how the change was tested, including both manual and automated tests)

Screenshots

Before After Vertical Padding = 4dp (Overriding Token)
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • Automated Tests
  • Documentation and demo app examples
  • VoiceOver and Keyboard Accessibility
  • Internationalization and RTL layouts
  • Size classes and window sizes (notched devices, multitasking, different window sizes, etc)

@Anubhvv Anubhvv requested a review from a team as a code owner May 11, 2024 18:28
@praveen970 praveen970 merged commit ea5b308 into microsoft:master May 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveen970 praveen970 praveen970 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anubhvv @praveen970