Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the job hosting to run the task count per queue type #3997

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

v-iyamauchi
Copy link
Contributor

@v-iyamauchi v-iyamauchi commented Jul 31, 2024

Updating the job hosting to run the max running task count per queue type.

Description

Added a new property, MaxRunningTaskCount, to HostingBackgroundServiceQueueItem. Also, changed JobHosting.ExecuteAsync to take an additional parameter "runningJobCount" that will allow us to run the number of tasks concurrently per a queue type.

Related issues

Addresses [issue #121963].

User Story 121963: Ensure Import on AKS runs with 4 workers (two per core)

Testing

Tested by locally running Fhir service. Also, with UTs for job hosting.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@v-iyamauchi v-iyamauchi added Enhancement Enhancement on existing functionality. Area-AKS Area related to Kubernetes labels Jul 31, 2024
@v-iyamauchi v-iyamauchi modified the milestones: backlog, S146 Jul 31, 2024
@v-iyamauchi v-iyamauchi added the Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs label Jul 31, 2024
@v-iyamauchi v-iyamauchi changed the title Update the job hosting to run the max running task count per queue type Update the job hosting to run the task count per queue type Jul 31, 2024
@v-iyamauchi v-iyamauchi marked this pull request as ready for review July 31, 2024 22:47
@v-iyamauchi v-iyamauchi requested a review from a team as a code owner July 31, 2024 22:47
mikaelweave
mikaelweave previously approved these changes Jul 31, 2024
Copy link
Contributor

@mikaelweave mikaelweave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple & elegant solution. I'm impressed.

@v-iyamauchi v-iyamauchi enabled auto-merge (squash) August 1, 2024 22:04
Copy link
Member

@brendankowitz brendankowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :shipit:

@v-iyamauchi v-iyamauchi merged commit c971d72 into main Aug 1, 2024
47 checks passed
@v-iyamauchi v-iyamauchi deleted the personal/v-iyamauchi/maxtaskcount-per-queue branch August 1, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AKS Area related to Kubernetes Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants