Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing flaky query plan test #3994

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Fixing flaky query plan test #3994

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
19c1d70
reset in the end
SergeyGaluzo Jul 30, 2024
e43b6a2
1 sec
SergeyGaluzo Jul 31, 2024
002026e
5
SergeyGaluzo Jul 31, 2024
c0660d1
tweak
SergeyGaluzo Jul 31, 2024
9cb1040
delay before query
SergeyGaluzo Jul 31, 2024
216d68e
more waits
SergeyGaluzo Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
1 sec
  • Loading branch information
@SergeyGaluzo
SergeyGaluzo committed Jul 31, 2024
commit e43b6a224766b8031621c5dba1d250da5aafef97
3 changes: 3 additions & 0 deletions test/Microsoft.Health.Fhir.Shared.Tests.Integration/Persistence/SqlComplexQueryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ public async Task GivenSearchQuery_IfReuseQueryPlansIsEnabled_ThenPlansAreReused
await ResetQueryStore();
SqlServerSearchService.ResetReuseQueryPlans();
await _fixture.SearchService.SearchAsync(KnownResourceTypes.Patient, [Tuple.Create("address-city", "City1")], CancellationToken.None);
await Task.Delay(1000);
await _fixture.SearchService.SearchAsync(KnownResourceTypes.Patient, [Tuple.Create("address-city", "City2")], CancellationToken.None);
//// values are different but plans are reused
await CheckQueryStore(2, 1);
Expand All @@ -61,6 +62,7 @@ public async Task GivenSearchQuery_IfReuseQueryPlansIsEnabled_ThenPlansAreReused
await ResetQueryStore();
SqlServerSearchService.ResetReuseQueryPlans();
await _fixture.SearchService.SearchAsync(KnownResourceTypes.Patient, [Tuple.Create("address-city", "City1")], CancellationToken.None);
await Task.Delay(1000);
await _fixture.SearchService.SearchAsync(KnownResourceTypes.Patient, [Tuple.Create("address-city", "City2")], CancellationToken.None);
//// values are different and plans are NOT reused
await CheckQueryStore(2, 2);
Expand All @@ -69,6 +71,7 @@ public async Task GivenSearchQuery_IfReuseQueryPlansIsEnabled_ThenPlansAreReused
await ResetQueryStore();
SqlServerSearchService.ResetReuseQueryPlans();
await _fixture.SearchService.SearchAsync(KnownResourceTypes.Patient, [Tuple.Create("address-city", "City1")], CancellationToken.None);
await Task.Delay(1000);
await _fixture.SearchService.SearchAsync(KnownResourceTypes.Patient, [Tuple.Create("address-city", "City1")], CancellationToken.None);
//// values are same and plans are reused
await CheckQueryStore(2, 1);
Expand Down
Loading