Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

macros/class: Fix HashSet contains+inserts pair to only lookup once #225

Merged
merged 3 commits into from
Nov 1, 2021
Merged

macros/class: Fix HashSet contains+inserts pair to only lookup once #225

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
331cc22
macros/class: Fix HashSet contains+inserts pair to only lookup once
MarijnS95 Oct 20, 2021
5bd4da0
Merge branch 'master' into nit
rylev Oct 26, 2021
83806a7
Merge branch 'master' into nit
rylev Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions macros/support/src/class/class.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,11 @@ impl Class {
let chain_ident = interface.chain_ident(index);
let ref_count_ident = crate::utils::ref_count_ident();

for interface_path in interface.iter_chain() {
for interface_path in interface
.iter_chain()
// Avoid generating duplicate From implementations
if interfaces_seen.contains(interface_path) {
continue;
}
interfaces_seen.insert(interface_path);

.filter(|interface_path| interfaces_seen.insert(interface_path))
{
output.extend(quote! {
impl<'a> ::core::convert::From<&'a #class_name> for #interface_path {
fn from(class: &'a #class_name) -> Self {
Expand Down