Convert AddressBook framework to C++/WinRT #2474
Conversation
| @@ -41,6 +41,10 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\Frameworks\include\CppUtils.h" /> | |||
| <ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\unittests\Tests.Shared\ByteUtils.h" /> | |||
There was a problem hiding this comment.
[](start = 4, length = 100)
This change is accidental. I'll remove it.
|
@ms-jihua is added to the review. #Closed |
| @@ -172,22 +200,36 @@ - (id)init { | |||
| return self; | |||
| } | |||
|
|
|||
| @dynamic contactStore; | |||
There was a problem hiding this comment.
No need for this if you're implementing it directly under it. Also, @dynamic isn't for manually-implemented properties; it's more for "these will exist at runtime, compiler, I promise"
There was a problem hiding this comment.
I believe I need @dynamic to suppress auto-generation of the field backing the property, don't I?
There was a problem hiding this comment.
Huh. It looks like the goal posts keep moving on what/when autosynthesis is engaged. Github does not have an emoticon that is glowering quite enough for me to express myself.
There was a problem hiding this comment.
I would be happy enough to let autosynthesis do its thing, except that in this case I want the property and the synthesized field to have different types.
There was a problem hiding this comment.
Nah, you're right to use @dynamic here. :)
This change removes uses of projections from the AddressBook framework and replaces them with C++/WinRT.