Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable #57896 (Respect package.json "type" and module-format-specific file extensions in more module modes) #58831

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Disable #57896 (Respect package.json "type" and module-format-specific file extensions in more module modes) #58831

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
592197d
Re-disable impliedNodeFormat setting outside of node16/nodenext
andrewbranch Jun 11, 2024
0e9eefe
Add trace baselines
andrewbranch Jun 11, 2024
61a3fac
Add unit test baselines
andrewbranch Jun 11, 2024
aeccaf5
Add compiler test baselines
andrewbranch Jun 11, 2024
198c386
Merge branch 'main' into disable-57896
andrewbranch Jun 12, 2024
1ab44d1
Update new baselines
andrewbranch Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update new baselines
  • Loading branch information
@andrewbranch
andrewbranch committed Jun 12, 2024
commit 1ab44d1ef58360d56e708c6d9f422205d116c199
56 changes: 8 additions & 48 deletions ...etely-when-command-line-incremental-flag-changes-between-non-dts-changes-discrepancies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,10 @@ CleanBuild:
IncrementalBuild:
{
"fileInfos": {
"../../../../lib/lib.d.ts": {
"version": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
"impliedFormat": "commonjs"
},
"../../../first/bin/first-output.d.ts": {
"version": "-15957783529-interface TheFirst {\n none: any;\n}\ndeclare const s = \"Hello, world\";\ninterface NoJsForHereEither {\n none: any;\n}\ndeclare function f(): string;\n",
"impliedFormat": "commonjs"
},
"../../../2/second-output.d.ts": {
"version": "-2513601205-declare namespace N {\n}\ndeclare namespace N {\n}\ndeclare class C {\n doSomething(): void;\n}\n",
"impliedFormat": "commonjs"
},
"../../third_part1.ts": {
"version": "7305100057-var c = new C();\nc.doSomething();\n",
"impliedFormat": "commonjs"
}
"../../../../lib/lib.d.ts": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
"../../../first/bin/first-output.d.ts": "-15957783529-interface TheFirst {\n none: any;\n}\ndeclare const s = \"Hello, world\";\ninterface NoJsForHereEither {\n none: any;\n}\ndeclare function f(): string;\n",
"../../../2/second-output.d.ts": "-2513601205-declare namespace N {\n}\ndeclare namespace N {\n}\ndeclare class C {\n doSomething(): void;\n}\n",
"../../third_part1.ts": "7305100057-var c = new C();\nc.doSomething();\n"
},
"root": [
[
Expand All @@ -49,36 +37,8 @@ CleanBuild:

IncrementalBuild:
{
"../../../../lib/lib.d.ts": {
"original": {
"version": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
"impliedFormat": 1
},
"version": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
"impliedFormat": "commonjs"
},
"../../../first/bin/first-output.d.ts": {
"original": {
"version": "-15957783529-interface TheFirst {\n none: any;\n}\ndeclare const s = \"Hello, world\";\ninterface NoJsForHereEither {\n none: any;\n}\ndeclare function f(): string;\n",
"impliedFormat": 1
},
"version": "-15957783529-interface TheFirst {\n none: any;\n}\ndeclare const s = \"Hello, world\";\ninterface NoJsForHereEither {\n none: any;\n}\ndeclare function f(): string;\n",
"impliedFormat": "commonjs"
},
"../../../2/second-output.d.ts": {
"original": {
"version": "-2513601205-declare namespace N {\n}\ndeclare namespace N {\n}\ndeclare class C {\n doSomething(): void;\n}\n",
"impliedFormat": 1
},
"version": "-2513601205-declare namespace N {\n}\ndeclare namespace N {\n}\ndeclare class C {\n doSomething(): void;\n}\n",
"impliedFormat": "commonjs"
},
"../../third_part1.ts": {
"original": {
"version": "7305100057-var c = new C();\nc.doSomething();\n",
"impliedFormat": 1
},
"version": "7305100057-var c = new C();\nc.doSomething();\n",
"impliedFormat": "commonjs"
}
"../../../../lib/lib.d.ts": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
"../../../first/bin/first-output.d.ts": "-15957783529-interface TheFirst {\n none: any;\n}\ndeclare const s = \"Hello, world\";\ninterface NoJsForHereEither {\n none: any;\n}\ndeclare function f(): string;\n",
"../../../2/second-output.d.ts": "-2513601205-declare namespace N {\n}\ndeclare namespace N {\n}\ndeclare class C {\n doSomething(): void;\n}\n",
"../../third_part1.ts": "7305100057-var c = new C();\nc.doSomething();\n"
}
16 changes: 6 additions & 10 deletions ...thRootDirInParent/reports-error-for-same-tsbuildinfo-file-without-incremental-with-tsc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ exports.Other = 0;


//// [/src/dist/tsconfig.tsbuildinfo]
{"fileNames":["../../lib/lib.d.ts","../src/other/other.ts"],"fileInfos":[{"version":"3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };","affectsGlobalScope":true,"impliedFormat":1},{"version":"-4254247902-export const Other = 0;\n","signature":"-10003600206-export declare const Other = 0;\n","impliedFormat":1}],"root":[2],"options":{"composite":true,"outDir":"./"},"latestChangedDtsFile":"./other.d.ts","version":"FakeTSVersion"}
{"fileNames":["../../lib/lib.d.ts","../src/other/other.ts"],"fileInfos":[{"version":"3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };","affectsGlobalScope":true},{"version":"-4254247902-export const Other = 0;\n","signature":"-10003600206-export declare const Other = 0;\n"}],"root":[2],"options":{"composite":true,"outDir":"./"},"latestChangedDtsFile":"./other.d.ts","version":"FakeTSVersion"}

//// [/src/dist/tsconfig.tsbuildinfo.readable.baseline.txt]
{
Expand All @@ -100,23 +100,19 @@ exports.Other = 0;
"../../lib/lib.d.ts": {
"original": {
"version": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
"affectsGlobalScope": true,
"impliedFormat": 1
"affectsGlobalScope": true
},
"version": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
"signature": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
"affectsGlobalScope": true,
"impliedFormat": "commonjs"
"affectsGlobalScope": true
},
"../src/other/other.ts": {
"original": {
"version": "-4254247902-export const Other = 0;\n",
"signature": "-10003600206-export declare const Other = 0;\n",
"impliedFormat": 1
"signature": "-10003600206-export declare const Other = 0;\n"
},
"version": "-4254247902-export const Other = 0;\n",
"signature": "-10003600206-export declare const Other = 0;\n",
"impliedFormat": "commonjs"
"signature": "-10003600206-export declare const Other = 0;\n"
}
},
"root": [
Expand All @@ -131,7 +127,7 @@ exports.Other = 0;
},
"latestChangedDtsFile": "./other.d.ts",
"version": "FakeTSVersion",
"size": 820
"size": 784
}


Expand Down
16 changes: 6 additions & 10 deletions ...ferenceWithRootDirInParent/reports-error-for-same-tsbuildinfo-file-without-incremental.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ exports.Other = 0;


//// [/src/dist/tsconfig.tsbuildinfo]
{"fileNames":["../../lib/lib.d.ts","../src/other/other.ts"],"fileInfos":[{"version":"3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };","affectsGlobalScope":true,"impliedFormat":1},{"version":"-4254247902-export const Other = 0;\n","signature":"-10003600206-export declare const Other = 0;\n","impliedFormat":1}],"root":[2],"options":{"composite":true,"outDir":"./"},"latestChangedDtsFile":"./other.d.ts","version":"FakeTSVersion"}
{"fileNames":["../../lib/lib.d.ts","../src/other/other.ts"],"fileInfos":[{"version":"3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };","affectsGlobalScope":true},{"version":"-4254247902-export const Other = 0;\n","signature":"-10003600206-export declare const Other = 0;\n"}],"root":[2],"options":{"composite":true,"outDir":"./"},"latestChangedDtsFile":"./other.d.ts","version":"FakeTSVersion"}

//// [/src/dist/tsconfig.tsbuildinfo.readable.baseline.txt]
{
Expand All @@ -117,23 +117,19 @@ exports.Other = 0;
"../../lib/lib.d.ts": {
"original": {
"version": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
"affectsGlobalScope": true,
"impliedFormat": 1
"affectsGlobalScope": true
},
"version": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
"signature": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
"affectsGlobalScope": true,
"impliedFormat": "commonjs"
"affectsGlobalScope": true
},
"../src/other/other.ts": {
"original": {
"version": "-4254247902-export const Other = 0;\n",
"signature": "-10003600206-export declare const Other = 0;\n",
"impliedFormat": 1
"signature": "-10003600206-export declare const Other = 0;\n"
},
"version": "-4254247902-export const Other = 0;\n",
"signature": "-10003600206-export declare const Other = 0;\n",
"impliedFormat": "commonjs"
"signature": "-10003600206-export declare const Other = 0;\n"
}
},
"root": [
Expand All @@ -148,6 +144,6 @@ exports.Other = 0;
},
"latestChangedDtsFile": "./other.d.ts",
"version": "FakeTSVersion",
"size": 820
"size": 784
}