Consistently respect --no-typecheck flag in build #51575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
commented
Nov 17, 2022
| @@ -610,7 +611,7 @@ export const watchLocal = task({ | |||
| dependencies: [localize, watchTsc, watchTsserver, watchServices, watchLssl, watchOtherOutputs, dts, watchSrc], | |||
| }); | |||
|
|
|||
| const runtestsDeps = [tests, generateLibs].concat(cmdLineOptions.typecheck ? [dts, buildSrc] : []); | |||
| const runtestsDeps = [tests, generateLibs].concat(cmdLineOptions.typecheck ? [dts] : []); | |||
There was a problem hiding this comment.
This is the one odd case; when typechecking is disabled, I skip the dts task. This is how we can go fast for quick F5s.
Potentially, this should be its own flag for tasks.json instead.
sheetalkamat
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PRs, we've been tweaking when typechecking happens in the new build system. It's currently the case that you get typechecking when you run
local,min, or one of theruntests, but not when you runtsc,tsserver,lssl, etc.Now that we have the
--no-typecheckbuild flag, it seems like it makes more sense to have the default behavior be consistent across all of our tasks, opting for the safer choice of--typecheck.I have changed our launch task to continue to not typecheck, as I think that's likely the most valuable place to pass this flag.