Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert scripts/Gulpfile to checked mjs/cjs so they can run without compilation #50988

Merged
merged 13 commits into from
Oct 7, 2022
Merged

Convert scripts/Gulpfile to checked mjs/cjs so they can run without compilation #50988

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8ffcd57
Transition everything to mjs or cjs
jakebailey Sep 29, 2022
2d0e8d5
Get stuff working
jakebailey Sep 29, 2022
6ff357f
Don't build eslint rules
jakebailey Sep 29, 2022
e3e0435
Don't build scripts until test time
jakebailey Sep 29, 2022
f94964e
Remove old comments
jakebailey Sep 29, 2022
0a9f9fa
Work around tsc -b problem with scripts and src
jakebailey Sep 29, 2022
e68528f
Merge branch 'main' into pure-js-scripts-1
jakebailey Sep 29, 2022
3df6fbd
Only typecheck scripts in CI
jakebailey Sep 29, 2022
0b0a7b6
Don't run LKG build test when testing eslint rules
jakebailey Sep 29, 2022
3bd2ba8
Merge branch 'main' into pure-js-scripts-1
jakebailey Oct 4, 2022
4680b7b
Remove bad eslint comment
jakebailey Oct 7, 2022
bcf6b7e
Merge branch 'main' into pure-js-scripts-1
jakebailey Oct 7, 2022
1de2c93
Merge branch 'main' into pure-js-scripts-1
jakebailey Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't build eslint rules
  • Loading branch information
@jakebailey
jakebailey committed Sep 29, 2022
commit 6ff357f1ab5db49686b8d48a309382ebdb5a63f3
13 changes: 2 additions & 11 deletions Gulpfile.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,17 +337,8 @@ task("clean-tests").description = "Cleans the outputs for the test infrastructur

const watchTests = () => watchProject("src/testRunner", cmdLineOptions);

const buildEslintRules = () => buildProject("scripts/eslint");
task("build-eslint-rules", buildEslintRules);
task("build-eslint-rules").description = "Compiles eslint rules to js";

const cleanEslintRules = () => cleanProject("scripts/eslint");
cleanTasks.push(cleanEslintRules);
task("clean-eslint-rules", cleanEslintRules);
task("clean-eslint-rules").description = "Cleans the outputs for the eslint rules";

const runEslintRulesTests = () => runConsoleTests("scripts/eslint/built/tests", "mocha-fivemat-progress-reporter", /*runInParallel*/ false, /*watchMode*/ false);
task("run-eslint-rules-tests", series(buildEslintRules, runEslintRulesTests));
const runEslintRulesTests = () => runConsoleTests("scripts/eslint/tests", "mocha-fivemat-progress-reporter", /*runInParallel*/ false, /*watchMode*/ false);
task("run-eslint-rules-tests", series(buildScripts, runEslintRulesTests));
task("run-eslint-rules-tests").description = "Runs the eslint rule tests";

/** @type { (folder: string) => { (): Promise<any>; displayName?: string } } */
Expand Down