Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement P1147R1 "Printing volatile Pointers" #2262

Merged
merged 12 commits into from
Oct 20, 2021
Merged

Implement P1147R1 "Printing volatile Pointers" #2262

merged 12 commits into from
Oct 20, 2021

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Oct 6, 2021

Fixes #2246

@fsb4000 fsb4000 requested a review from a team as a code owner October 6, 2021 15:39
@fsb4000 fsb4000 changed the title Implemented P1147R1 "Printing volatile Pointers" Implement P1147R1 "Printing volatile Pointers" Oct 6, 2021
@CaseyCarter CaseyCarter added defect report Applied retroactively format C++20/23 format labels Oct 6, 2021
@CaseyCarter

This comment has been minimized.

Sign in to view
@CaseyCarter

This comment has been minimized.

Sign in to view
@CaseyCarter CaseyCarter added cxx23 C++23 feature and removed format C++20/23 format defect report Applied retroactively labels Oct 6, 2021
CaseyCarter
CaseyCarter requested changes Oct 13, 2021
View reviewed changes
tests/std/test.lst Outdated Show resolved Hide resolved
tests/std/tests/P1147R1_printing_volotile_pointers/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P1147R1_printing_volotile_pointers/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P1147R1_printing_volotile_pointers/test.cpp Outdated Show resolved Hide resolved
stl/inc/ostream Outdated Show resolved Hide resolved
stl/inc/ostream Outdated Show resolved Hide resolved
StephanTLavavej
StephanTLavavej reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good, I'll push changes for incredibly minor nitpicks.

tests/std/tests/P1147R1_printing_volatile_pointers/test.cpp Show resolved Hide resolved
stl/inc/ostream Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Oct 19, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to an MSVC-internal PR; please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

I've pushed a merge with main, resolving a trivial adjacent-add conflict in yvals_core.h.

@StephanTLavavej StephanTLavavej merged commit 486a8a1 into microsoft:main Oct 20, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing this highly volatile feature! 💥 😹 ✔️

@fsb4000 fsb4000 deleted the fix2246 branch October 20, 2021 14:10
RSilicon pushed a commit to RSilicon/STL that referenced this pull request Nov 4, 2021
@fsb4000 @CaseyCarter
@StephanTLavavej @RSilicon
Implement P1147R1 "Printing volatile Pointers" (microsoft#2262)
4726324 
Co-authored-by: Casey Carter <Casey@Carter.net>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@AlexGuteniev AlexGuteniev AlexGuteniev approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P1147R1 Printing volatile Pointers
4 participants
@fsb4000 @CaseyCarter @StephanTLavavej @AlexGuteniev