Listen and modify client messages to make code actions work #7876
Conversation
|
| // We need to keep listening if debugging or haven't modified initialize yet | ||
| return Tuple.Create(data, !_modifiedInitialize || _isDebugging); | ||
| // For now we will keep listening since code action requests can be sent multiple times | ||
| return Tuple.Create(data, true); |
There was a problem hiding this comment.
I don't know enough about this to say whether or not this change is valid. The rest looks good though :)
There was a problem hiding this comment.
This boolean value is used to determine whether to set the writeHandler of StreamIntercepter to null. Previously I think the intent was to modify the initialization message and stop the listening for perf considerations. My change is basically never set the writeHandler to null.
There was a problem hiding this comment.
I guess my question would be if it's correct to change this behavior? Do the perf considerations no longer apply?
There was a problem hiding this comment.
For code actions, at least I didn't notice any slowness. For other messages, it will bail out early since the if condition is not met.
fixes #7864
In the code action requests that VS client sends, the
_vs_selectionRangeis supposed to be therangeproperty that Pylance can understand, so intercept the messages and modify the property to make code actions work.