Update/remove some deps using old semver #22420
Conversation
github-actions
bot
added
area: examples
| "@changesets/cli": "^2.26.1", | ||
| "@changesets/types": "^5.2.1", | ||
| "@changesets/cli": "^2.27.8", | ||
| "@changesets/types": "^6.0.0", |
There was a problem hiding this comment.
Not sure this is safe. There is interplay between this package and build-tools. Do the release notes say anything about why it's a major release?
There was a problem hiding this comment.
It's due to this change, which I don't think should matter to us?
changesets/changesets#1185 (comment)
(was originally checked in as minor, then readjusted to major):
changesets/changesets#1186
https://github.com/changesets/changesets/releases/tag/%40changesets%2Ftypes%406.0.0
There was a problem hiding this comment.
Ha, yeah, that shouldn't affect us because we have modernized our build-env already. Yay!
| @@ -42,7 +42,7 @@ | |||
| "@fluidframework/eslint-config-fluid": "^5.4.0", | |||
| "eslint": "~8.55.0", | |||
| "eslint-config-prettier": "~9.0.0", | |||
| "pm2": "^5.3.1", | |||
| "pm2": "^5.4.2", | |||
There was a problem hiding this comment.
I replaced forever with pm2 in #19459. I remember some discussion after that at some point and IIRC my take then was "we probably don't need pm2 where we use it, it's just a convenience; if anyone wants to find an alternative or just get rid of it, feel free". That said, I went through the legal review process it needed due to its licensing and we're ok to use it as a dev dependency, so we're not in urgent need of doing something about it.
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 35610c0 |
Updates:
pm2@changesets/cli@changesets/typessasssass-loaderRemoves
typescript-formatterWhile looking at dependabot alerts (specifically around old semver dependencies) found these low-hanging fruit to help. Does not fully resolve the alert, but improves upon current.