Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: More schema cleanup #22322

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

CraigMacomber
Copy link
Contributor

Description

Reduce use of SchemaBuilderInternal.

Fix missing sort when persisting field schema found while editing test schema: this is not a correctness issue, but should improve consistency and thus blob reuse in the encoded format.

Reviewer Guidance

The review process is outlined on this wiki page.

@CraigMacomber CraigMacomber requested a review from a team as a code owner August 27, 2024 22:01
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels Aug 27, 2024
@@ -221,83 +215,6 @@ describe("SharedTree", () => {
});
});

describe("requireSchema", () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests are for a function, requireSchema, that is no longer in the file this file is testing. schematizingTreeView.spec.ts
is the proper place for these, and it has relatively good coverage already, so only one of these two tests was ported to it.

@CraigMacomber CraigMacomber enabled auto-merge (squash) August 27, 2024 22:25
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +259 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 459.99 KB 460.03 KB +35 Bytes
azureClient.js 558.03 KB 558.07 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 260.81 KB 260.82 KB +14 Bytes
fluidFramework.js 402.98 KB 403 KB +21 Bytes
loader.js 134.26 KB 134.28 KB +14 Bytes
map.js 42.3 KB 42.31 KB +7 Bytes
matrix.js 146.47 KB 146.48 KB +7 Bytes
odspClient.js 525.31 KB 525.36 KB +49 Bytes
odspDriver.js 97.72 KB 97.74 KB +21 Bytes
odspPrefetchSnapshot.js 42.78 KB 42.79 KB +14 Bytes
sharedString.js 163.18 KB 163.18 KB +7 Bytes
sharedTree.js 393.49 KB 393.5 KB +14 Bytes
Total Size 3.3 MB 3.3 MB +259 Bytes

Baseline commit: c3f64a9

Generated by 🚫 dangerJS against 8b18121

@CraigMacomber CraigMacomber merged commit 961c9e8 into microsoft:main Aug 27, 2024
30 checks passed
@CraigMacomber CraigMacomber deleted the moreFlexCLeanup branch August 27, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants