Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert attributor to IFluidDataStoreChannel #22120

Merged
merged 12 commits into from
Aug 16, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
Jatin Garg authored and Jatin Garg committed Aug 5, 2024
commit 421c72746e89fe4e24e8c67087a23aecee505eea
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ export class RuntimeAttributorDataStoreChannel

assert(
this.visibilityState === VisibilityState.LocallyVisible,
0x2d1 /* "Data store should be locally visible before it can become globally visible." */,
"Data store should be locally visible before it can become globally visible.",
);

// Mark the data store globally visible and make its child channels visible as well.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ describeCompat("Attributor", "NoCompat", (getTestObjectProvider, apis) => {

const url = await container1.getAbsoluteUrl("");
assert(url !== undefined);
const loader2 = provider.makeTestLoader(getTestConfig());
const loader2 = provider.makeTestLoader(getTestConfig(true));
const container2 = await loader2.resolve({ url });

const sharedString2 = await sharedStringFromContainer(container2);
Expand Down
Loading