Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiview example cleanup #20120

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Conversation

ChumpChief
Copy link
Contributor

@ChumpChief ChumpChief commented Mar 14, 2024

Jason had a good suggestion to clean up the start scripts of the multiview packages that aren't intended to be run directly: #20085 (comment)

We can also clean up unnecessary dependencies and webpack tasks at the same time.

AB#7447

@github-actions github-actions bot added area: examples Changes that focus on our examples dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Mar 14, 2024
Copy link
Contributor

@jason-ha jason-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up - Love better examples

@ChumpChief ChumpChief merged commit bdca465 into microsoft:main Mar 15, 2024
31 checks passed
@ChumpChief ChumpChief deleted the MultiviewCleanup branch March 15, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Changes that focus on our examples base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants