Adding baseVersionForMinCompat for min compat version testing #20060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: tests
alexvy86
reviewed
Mar 12, 2024
packages/test/test-version-utils/src/test/minCompatVersion.spec.ts
Outdated
Show resolved
Hide resolved
|
Not entirely deterministic since we still use getRequestedVersion() underneath but at least N-i versions will be fixed and tests behavior shouldn't change before/after release |
dannimad
changed the title
tylerbutler
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time we release, the base version in which N-i calculations are based changes. This causes issues at testing specially at bumping the release version. By hard coding the version in which these calculations are made, we decoupled the min version testing from the release process, although we will need to update this hard coded value shortly after the release as after work to make sure that min versions are going to work with the new version. I really believe this is the best attempt so far to test this functionality, given that it's a middle ground between both contending arguments of making the tests deterministic and at the same time not requiring too much of maintenance.