build: Update API-Extractor, remove now-unneeded pnpm patches, and update API reports to reflect bug fix #19939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date API reports to reflect bug fix
github-actions
bot
added
area: build
Josmithr
commented
Mar 4, 2024
| @@ -25,7 +25,6 @@ export class AttributableMap extends SharedObject<ISharedMapEvents> implements I | |||
| [Symbol.iterator](): IterableIterator<[string, any]>; | |||
| readonly [Symbol.toStringTag]: string; | |||
| constructor(id: string, runtime: IFluidDataStoreRuntime, attributes: IChannelAttributes); | |||
| // (undocumented) | |||
There was a problem hiding this comment.
Anything that was previously documented using {@inheritDoc } pointing to a target in another library would be incorrectly annotated as (undocumented). This is now fixed!
Josmithr
commented
Mar 4, 2024
| @@ -122,7 +122,6 @@ | |||
| "@fluid-private/readme-command": "workspace:~", | |||
| "@fluidframework/build-common": "^2.0.3", | |||
| "@fluidframework/eslint-config-fluid": "^4.0.0", | |||
| "@microsoft/api-extractor": "^7.39.1", | |||
There was a problem hiding this comment.
This was duplicated between dependencies and devDependencies. This package uses api-extractor in code, so the devDependencies entry was removed.
Josmithr
changed the title
alexvy86
reviewed
Mar 4, 2024
⯅ @fluid-example/bundle-size-tests: +44 Bytes
Baseline commit: 7c4a08b |
alexvy86
approved these changes
Mar 4, 2024
Josmithr
added a commit
that referenced
this pull request
Apr 17, 2024
…e tag compatibility (#20696) Mitigation for API-Extractor [issue 4430](microsoft/rushstack#4430). The original mitigation we had in place was erroneously removed in #19939. Also fixes the handful of violations that have been introduced since that PR.
Josmithr
added a commit
that referenced
this pull request
Apr 17, 2024
…e tag compatibility (#20696) (#20699) Mitigation for API-Extractor [issue 4430](microsoft/rushstack#4430). The original mitigation we had in place was erroneously removed in #19939. Also fixes the handful of violations that have been introduced since that PR. Cherry-picked from #20696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noteworthy changes beyond dependency version bumps:
bundledPackagesentries in API-Extractor configs to use glob patterns instead of regular expressions.{@inheritDoc}comments as "undocumented" in API reports rushstack#3462(undocumented)when they leveraged TSDoc{@inheritDoc }comments in some cases.{@inheritDoc}comments as "undocumented" in API reports rushstack#3462See API-Extractor's changelog here: https://github.com/microsoft/rushstack/blob/main/apps/api-extractor/CHANGELOG.md#7423