-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CommonJS Testing #19868
Remove CommonJS Testing #19868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also esm then cjs scripts.
But we should see how this moves the overhead needle. If this group of changes is significant, then we don't need to do more. If it is not noticeable, then we know we should look at the other group.
⯅ @fluid-example/bundle-size-tests: +154 Bytes
Baseline commit: bdef6d1 |
I didn't find any script which esm followed by cjs. For tree dds, esm testing is skipped: https://github.com/microsoft/FluidFramework/blob/main/packages/dds/tree/package.json#L71 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of the build:test ordering. Ship it.
This PR eliminates CJS testing, resulting in nearly double the execution time for Mocha tests. This increase in time may stem from testing both cjs and esm module.