refactor: Remove more deprecated telemetry types from core-interfaces

[alexvy86]

Description

Removes the remaining deprecated telemetry-related types from core-interfaces:

• ITelemetryProperties (replaced with the public ITelemetryBaseProperties)
• TelemetryEventCategory (moved to @fluidframework/telemetry-utils in the past)
• TelemetryEventPropertyType (replaced with the equivalent, now-public TelemetryBaseEventPropertyType)
• ITaggedTelemetryPropertyType (replaced with the public Tagged<TelemetryBaseEventPropertyType>)

This is basically just a change in type names within our codebase, and removal of the deprecated types from the API surface of core-interfaces, plus corresponding guidance for consumers.

Breaking Changes

See description above. 3 types have equivalent replacements already available in the package so consumers would only need to update the names of types being imported. 1 type has its replacement in a different package, so consumers would need to change their import to come from the new package (potentially introducing a new dependency; in practice they probably already have this dependency).

Reviewer Guidance

The review process is outlined on this wiki page.

Particular things where I'd like feedback:

• ITaggedTelemetryPropertyType was internal but its replacement Tagged<TelemetryBaseEventPropertyType> is public. I think that's correct because consumers need to support tagged properties in telemetry events.

• TelemetryEventPropertyType was public and its replacement/equivalent TelemetryBaseEventPropertyType was alpha, but with the replacement became public to support all the scenarios where the deprecated type is being used. In particular, ITelemetryBaseProperties requires it to be public, which I think is fine.

[alexvy86]

/azp run Build - client packages

[alexvy86]

/azp run repo-policy-check

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[msfluid-bot]

⯅ @fluid-example/bundle-size-tests: +154 Bytes

Metric Name	Baseline Size	Compare Size	Size Diff
aqueduct.js	513.7 KB	513.74 KB	⯅ +44 Bytes
connectionState.js	680 Bytes	680 Bytes	■ No change
containerRuntime.js	247.81 KB	247.83 KB	⯅ +22 Bytes
loader.js	171.3 KB	171.32 KB	⯅ +22 Bytes
map.js	46.69 KB	46.7 KB	⯅ +11 Bytes
matrix.js	148.74 KB	148.74 KB	■ No change
odspDriver.js	97.31 KB	97.33 KB	⯅ +22 Bytes
odspPrefetchSnapshot.js	42.28 KB	42.29 KB	⯅ +11 Bytes
sharedString.js	167.32 KB	167.33 KB	⯅ +11 Bytes
sharedTree.js	334.63 KB	334.63 KB	■ No change
Total Size	1.87 MB	1.87 MB	⯅ +154 Bytes

---

Baseline commit: 1a73a3a

Generated by 🚫 dangerJS against 5a12cd6

[Josmithr]

1 documentation suggestion, and I sort of randomly suggested changing some import statements to be type-only - take them or leave them :)

Otherwise, looks good to me!