Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump server in client with prerelease packages #19690

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Feb 18, 2024

Description

Bump protocol-definitions, server-services-client, server-local-server, protocol-base, server-services-core, server-test-utils, and gitresources, tinylicious package versions in client repo.

Modified the ISnashotTree to add a prop: omitted to let service communicate to client whether it omitted the contents or not.
This change was made in protocol-defn package which was upgraded in server repo, and now upgrading server and protocol defn packages in client repo.

This is related to Data Virtualization.

@jatgarg jatgarg self-assigned this Feb 18, 2024
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Feb 18, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Feb 18, 2024

@fluid-example/bundle-size-tests: +187 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 511.94 KB 511.98 KB +44 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 244.62 KB 244.64 KB +22 Bytes
loader.js 170.65 KB 170.67 KB +22 Bytes
map.js 46.53 KB 46.54 KB +11 Bytes
matrix.js 148.88 KB 148.9 KB +11 Bytes
odspDriver.js 97.67 KB 97.7 KB +33 Bytes
odspPrefetchSnapshot.js 42.63 KB 42.65 KB +22 Bytes
sharedString.js 168.61 KB 168.62 KB +11 Bytes
sharedTree.js 334 KB 334 KB No change
Total Size 1.87 MB 1.87 MB +187 Bytes

Baseline commit: 55806cb

Generated by 🚫 dangerJS against 88e641a

@tylerbutler
Copy link
Member

I suggest not doing prereleases of server. It's a time bomb that will blow up for the person who has to do a server release before they can release client. Because server releases can contain all sorts of changes and the longer we leave it the changes will pile up and become a major hassle for the person who has to do the real server release.

If you need a server change, do a full server release, major version, and bump the client to use it.

@tylerbutler
Copy link
Member

That said, since the prerelease was already done, carry on. Maybe for next time, though, do a full server release.

@jatgarg jatgarg merged commit c7926f3 into microsoft:main Feb 20, 2024
30 checks passed
@jatgarg jatgarg deleted the clientproto branch February 20, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants