Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(build-tools): fixes for ESM builds #19625

Merged
merged 4 commits into from
Feb 14, 2024
Merged

improvement(build-tools): fixes for ESM builds #19625

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
690a15d
improvement(build-tools): generate typetest with full path
jason-ha Feb 13, 2024
98a3e2c
improvement(build-tools): policy fixes for ESM builds
jason-ha Feb 13, 2024
cdced90
fix(build-tools): tsc-multi incremental build
jason-ha Feb 14, 2024
2f93756
fix(build-tools): remove extraneous code
jason-ha Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
improvement(build-tools): generate typetest with full path
  • Loading branch information
@jason-ha
jason-ha committed Feb 14, 2024
commit 690a15df0d0fb2091bce1930cd2893195afe5f5f
2 changes: 1 addition & 1 deletion build-tools/packages/build-tools/src/type-test-generator/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ const testString: string[] = [
* Generated by fluid-type-test-generator in @fluidframework/build-tools.
*/
import type * as old from "${previousPackageName}";
import type * as current from "../../index";
import type * as current from "../../index.js";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to handle cjs/mjs here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think /index would be found as /index.cjs or /index.mjs, which makes this a non-change [except maybe in the case that index was a folder].
If we are building tests with tsc-multi and renaming (pattern we are going away from), then this would be renamed. If building only the product code with tsc-multi and renaming, then I think this was already broken.
Nothing broken on my local system when this was run for client group.

`,
typeOnly,
];
Expand Down