Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable minCompatVersion tests #19468

Merged
merged 4 commits into from
Feb 3, 2024
Merged

Conversation

dannimad
Copy link
Contributor

@dannimad dannimad commented Feb 2, 2024

Related https://dev.azure.com/fluidframework/internal/_workitems/edit/7089
No reason to have these tests enabled given that we disabled specifying minVersion in tests suites. Will bring them back once the issue is fixed
It also prevents people to use minVersion in our test suites

@dannimad dannimad requested a review from a team as a code owner February 2, 2024 23:24
@github-actions github-actions bot added area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Feb 2, 2024
@msfluid-bot
Copy link
Collaborator

Could not find a usable baseline build with search starting at CI 8fb4e5b

Generated by 🚫 dangerJS against 7b959f6

@dannimad dannimad merged commit 40127df into microsoft:main Feb 3, 2024
32 checks passed
@dannimad dannimad deleted the disabledmintests branch February 3, 2024 02:18
alexvy86 pushed a commit to alexvy86/FluidFramework that referenced this pull request Feb 13, 2024
Related
https://dev.azure.com/fluidframework/internal/_workitems/edit/7089
No reason to have these tests enabled given that we disabled specifying
minVersion in tests suites. Will bring them back once the issue is fixed
It also prevents people to use minVersion in our test suites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants