-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tree): insert* and move* should accept proxy API types #17972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
Issues related to distributed data structures
area: dds: tree
public api change
Changes to a public API
base: main
PRs targeted against main branch
labels
Oct 25, 2023
DLehenbauer
commented
Oct 25, 2023
DLehenbauer
commented
Oct 25, 2023
experimental/dds/tree2/src/feature-libraries/editable-tree-2/lazyField.ts
Show resolved
Hide resolved
DLehenbauer
commented
Oct 25, 2023
experimental/dds/tree2/src/feature-libraries/editable-tree-2/lazyField.ts
Show resolved
Hide resolved
DLehenbauer
commented
Oct 25, 2023
experimental/dds/tree2/src/feature-libraries/editable-tree-2/proxies/proxies.ts
Show resolved
Hide resolved
DLehenbauer
commented
Oct 25, 2023
experimental/dds/tree2/src/feature-libraries/editable-tree-2/proxies/proxies.ts
Show resolved
Hide resolved
DLehenbauer
commented
Oct 25, 2023
experimental/dds/tree2/src/feature-libraries/editable-tree-2/proxies/proxies.ts
Show resolved
Hide resolved
DLehenbauer
commented
Oct 25, 2023
experimental/dds/tree2/src/feature-libraries/editable-tree-2/proxies/proxies.ts
Show resolved
Hide resolved
DLehenbauer
commented
Oct 25, 2023
experimental/dds/tree2/src/feature-libraries/editable-tree-2/proxies/proxies.ts
Show resolved
Hide resolved
DLehenbauer
commented
Oct 25, 2023
experimental/dds/tree2/src/feature-libraries/editable-tree-2/proxies/proxies.ts
Show resolved
Hide resolved
DLehenbauer
commented
Oct 25, 2023
experimental/dds/tree2/src/feature-libraries/editable-tree-2/proxies/proxies.ts
Show resolved
Hide resolved
⯅ @fluid-example/bundle-size-tests: +311 Bytes
Baseline commit: 0d1436b |
DLehenbauer
commented
Oct 25, 2023
experimental/dds/tree2/src/test/feature-libraries/editable-tree-2/proxies.spec.ts
Show resolved
Hide resolved
noencke
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
if (destinationIndex > sourceStart) { | ||
destinationIndex = | ||
destinationIndex < sourceEnd | ||
? sourceStart // distination overlaps with source range -> slide to left |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
? sourceStart // distination overlaps with source range -> slide to left | |
? sourceStart // destination overlaps with source range -> slide to left |
This typo made me realize that while "src" and "dest" are opposites, so are "src" and "dist".
experimental/dds/tree2/src/feature-libraries/editable-tree-2/proxies/proxies.ts
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/editable-tree-2/proxies/proxies.ts
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/editable-tree-2/proxies/proxies.ts
Show resolved
Hide resolved
experimental/dds/tree2/src/feature-libraries/editable-tree-2/proxies/proxies.ts
Show resolved
Hide resolved
experimental/dds/tree2/src/test/feature-libraries/editable-tree-2/proxies.spec.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: tree
area: dds
Issues related to distributed data structures
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharedListNode.insert*() needed adjustment to accept the new factory-created content.
SharedListNode.move*() needed adjustment to accept to accept a SharedListNode as source.
Testing also uncovered and fixed a couple of minor bugs in the move implementation: