-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix op compression when using an older loader #14337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: runtime
Runtime related issues
area: tests
Tests to add, test infrastructure improvements, etc
base: main
PRs targeted against main branch
labels
Feb 27, 2023
vladsud
reviewed
Feb 27, 2023
vladsud
reviewed
Feb 27, 2023
packages/runtime/container-runtime/src/opLifecycle/opDecompressor.ts
Outdated
Show resolved
Hide resolved
vladsud
reviewed
Feb 27, 2023
packages/runtime/container-runtime/src/opLifecycle/opDecompressor.ts
Outdated
Show resolved
Hide resolved
vladsud
reviewed
Feb 27, 2023
packages/runtime/container-runtime/src/opLifecycle/opDecompressor.ts
Outdated
Show resolved
Hide resolved
vladsud
reviewed
Feb 27, 2023
vladsud
approved these changes
Feb 27, 2023
github-actions
bot
removed
the
area: tests
Tests to add, test infrastructure improvements, etc
label
Feb 27, 2023
⯅ @fluid-example/bundle-size-tests: +1.77 KB
Baseline commit: 1df94c8 |
github-actions
bot
added
the
area: tests
Tests to add, test infrastructure improvements, etc
label
Feb 27, 2023
andre4i
added a commit
that referenced
this pull request
Feb 27, 2023
## Description Porting #14337 to the release branch # NOTE TO REVIEWERS **As [release/v2int/3.0](https://github.com/microsoft/FluidFramework/tree/release/v2int/3.0) was cut before we moved to tabs, this PR was not done using `cherry-pick`. It was done manually on a fresh branch off the review branch. Please spot check this and be extra careful about the diff between this and #14337
andre4i
added a commit
to andre4i/FluidFramework
that referenced
this pull request
Feb 28, 2023
## Description ADO:3538 For loaders older than client_v2.0.0-internal.1.2.0 (exclusive), compression gracefully does not work (it does happen, but the messages are eventually sent uncompressed over the wire) However, for loaders between client_v2.0.0-internal.1.2.0 (inclusive) and client_v2.0.0-internal.2.2.0 (exclusive), the runtime will provide the loader with the compression field but the delta manager, on the loader side will ignore that field. Therefore, the message is sent over the wire without any compression markers. This means that no client is able to process this compressed message as it has no compression marker, and the container will close with assert `0x3ce` (`Runtime message of unknown type`). **To work around this, the runtime must figure out if the message is compressed based on its 'shape'** This change also replaces the assert with an explicit data processing error.
andre4i
added a commit
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: runtime
Runtime related issues
area: tests
Tests to add, test infrastructure improvements, etc
base: main
PRs targeted against main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AB#3538
For loaders older than client_v2.0.0-internal.1.2.0 (exclusive), compression gracefully does not work (it does happen, but the messages are eventually sent uncompressed over the wire)
However, for loaders between client_v2.0.0-internal.1.2.0 (inclusive) and client_v2.0.0-internal.2.2.0 (exclusive), the runtime will provide the loader with the compression field as such:
but the delta manager, on the loader side will ignore that field. Therefore, the message is sent over the wire without any compression markers. This means that no client is able to process this compressed message as it has no compression marker, and the container will close with assert
0x3ce
(Runtime message of unknown type
).To work around this, the runtime must figure out if the message is compressed based on its 'shape'
This change also replaces the assert with an explicit data processing error.