Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow FlushModeExperimental.Async if the loader does not support reference sequence numbers #14239

Merged
merged 30 commits into from
Feb 21, 2023
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
fd6f187
Flush partial batches whenever we find a reference sequence number mi…
andre4i Feb 8, 2023
9963595
Add some tests
andre4i Feb 8, 2023
47a1db7
Revert
andre4i Feb 8, 2023
a565c35
Rename
andre4i Feb 9, 2023
528df5d
Move reference sequence number to the runtime
andre4i Feb 13, 2023
6366d52
Add test
andre4i Feb 13, 2023
0576c24
Fix test, remove tracking from the runtime
andre4i Feb 14, 2023
e4e9239
Merge branch 'flush_when_ref_mismatch' into move-refseqnum-to-runtime
andre4i Feb 14, 2023
4b93dbb
Fix logging, docs
andre4i Feb 14, 2023
bd5a48f
Merge branch 'main' into move-refseqnum-to-runtime
andre4i Feb 14, 2023
08509e5
Add tests
andre4i Feb 14, 2023
41e621c
Merge branch 'main' into move-refseqnum-to-runtime
andre4i Feb 14, 2023
cd4d479
One refseqnum per each batch
andre4i Feb 15, 2023
7f39fa9
Update docs
andre4i Feb 15, 2023
daa6011
Add optional refseqnum to submitSummaryFn
andre4i Feb 15, 2023
a245344
Merge branch 'main' into move-refseqnum-to-runtime
andre4i Feb 15, 2023
dc57b90
PR feedback
andre4i Feb 15, 2023
ac23358
Merge branch 'main' into move-refseqnum-to-runtime
andre4i Feb 16, 2023
0b93990
Old loaders should not work with FlushMode.Async
andre4i Feb 17, 2023
65bc0b2
PR feedback
andre4i Feb 17, 2023
35e0464
Do not assert if partial flush is disabled
andre4i Feb 17, 2023
1fa1954
Submit reference sequence number with summaries
andre4i Feb 17, 2023
2ef06ee
Merge branch 'move-refseqnum-to-runtime' into disallow-async-with-old…
andre4i Feb 17, 2023
514c69d
Merge branch 'main' into move-refseqnum-to-runtime
andre4i Feb 17, 2023
d4104e1
Merge branch 'move-refseqnum-to-runtime' into disallow-async-with-old…
andre4i Feb 17, 2023
159a99f
Add test
andre4i Feb 17, 2023
0a4f600
Merge branch 'main' into disallow-async-with-old-loader
andre4i Feb 17, 2023
e3dc722
Update docs
andre4i Feb 17, 2023
403b316
Do not close the container
andre4i Feb 17, 2023
4b5cb94
Merge branch 'main' into disallow-async-with-old-loader
andre4i Feb 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into disallow-async-with-old-loader
  • Loading branch information
andre4i committed Feb 17, 2023
commit 0a4f600c236bac081c8d8a8c7579751e7fb5b15f
4 changes: 1 addition & 3 deletions packages/runtime/container-runtime/src/containerRuntime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1296,9 +1296,7 @@ export class ContainerRuntime
config: {
compressionOptions,
maxBatchSizeInBytes: runtimeOptions.maxBatchSizeInBytes,
disablePartialFlush:
this.mc.config.getBoolean("Fluid.ContainerRuntime.DisablePartialFlush") ===
true,
disablePartialFlush: disablePartialFlush === true,
},
logger: this.mc.logger,
});
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.