Re-enable back-compat testing for compression #13624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: tests
tyler-cai-microsoft
approved these changes
Feb 1, 2023
zhenmichael
pushed a commit
that referenced
this pull request
Feb 2, 2023
## Description ADO:2942 They have been disabled initially because the new runtime: - [sends the compression message field to the loader](https://github.com/microsoft/FluidFramework/blob/65a7a49c82caa09e8af9a6473a5802096f861e66/packages/runtime/container-runtime/src/opLifecycle/outbox.ts#L193) - does not send or check the metadata compression field anymore therefore, new runtimes will not be able to process the old compressed batches as they won't have the message-level compression field and the metadata compression field is ignored. The PR tests are expected to fail until a new version is released. Afterwards, it will be merged.
daesun-park
pushed a commit
to daesun-park/FluidFramework
that referenced
this pull request
Feb 8, 2023
## Description ADO:2942 They have been disabled initially because the new runtime: - [sends the compression message field to the loader](https://github.com/microsoft/FluidFramework/blob/65a7a49c82caa09e8af9a6473a5802096f861e66/packages/runtime/container-runtime/src/opLifecycle/outbox.ts#L193) - does not send or check the metadata compression field anymore therefore, new runtimes will not be able to process the old compressed batches as they won't have the message-level compression field and the metadata compression field is ignored. The PR tests are expected to fail until a new version is released. Afterwards, it will be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADO:2942
They have been disabled initially because the new runtime:
therefore, new runtimes will not be able to process the old compressed batches as they won't have the message-level compression field and the metadata compression field is ignored.
The PR tests are expected to fail until a new version is released. Afterwards, it will be merged.