Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for disabling both compression and chunking via feature gates #13578

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

andre4i
Copy link
Contributor

@andre4i andre4i commented Jan 11, 2023

Even if the features are enabled using the container runtime config (through code), this change adds the option of disabling the features (in case of emergency) without code changes.

Regardless of configs or feature gates, compression/chunking is not disabled on the receiving end. Any client will be able to process compressed and or chunked ops. The configs/feature gates are relative to the producer of the ops, not the consumer.

@github-actions github-actions bot added base: main PRs targeted against main branch area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc labels Jan 11, 2023
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Jan 11, 2023

@fluid-example/bundle-size-tests: +548 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 422.59 KB 422.86 KB +274 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 217.36 KB 217.62 KB +274 Bytes
loader.js 156.25 KB 156.25 KB No change
map.js 43.63 KB 43.63 KB No change
matrix.js 136.82 KB 136.82 KB No change
odspDriver.js 100.99 KB 100.99 KB No change
odspPrefetchSnapshot.js 42.07 KB 42.07 KB No change
sharedString.js 156.94 KB 156.94 KB No change
Total Size 1.34 MB 1.34 MB +548 Bytes

Baseline commit: c1dd970

Generated by 🚫 dangerJS against 60f8752

@andre4i andre4i marked this pull request as ready for review January 11, 2023 19:08
@andre4i andre4i requested review from a team as code owners January 11, 2023 19:08
@andre4i andre4i requested a review from vladsud January 12, 2023 16:55
@andre4i andre4i merged commit 2cce364 into microsoft:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants