Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stress test for chunked payloads with compression #13431

Merged
merged 19 commits into from
Jan 31, 2023
Merged

Add stress test for chunked payloads with compression #13431

merged 19 commits into from
Jan 31, 2023

Conversation

andre4i
Copy link
Contributor

@andre4i andre4i commented Dec 21, 2022

Part of ADO:2089

The goal is to constantly stress test the feature added as part of #13329

@github-actions github-actions bot added area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Dec 21, 2022
@github-actions github-actions bot added the area: runtime Runtime related issues label Dec 21, 2022
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Dec 21, 2022 •
edited
Loading

⯅ @fluid-example/bundle-size-tests: +514 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 426.22 KB 426.48 KB ⯅ +257 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 219.58 KB 219.83 KB ⯅ +257 Bytes
loader.js 158.48 KB 158.48 KB ■ No change
map.js 43.85 KB 43.85 KB ■ No change
matrix.js 137.38 KB 137.38 KB ■ No change
odspDriver.js 91.1 KB 91.1 KB ■ No change
odspPrefetchSnapshot.js 42.39 KB 42.39 KB ■ No change
sharedString.js 158.14 KB 158.14 KB ■ No change
Total Size 1.35 MB 1.35 MB ⯅ +514 Bytes

Baseline commit: d730964

Generated by 🚫 dangerJS against 3d517f7

@github-actions github-actions bot added the area: build Build related issues label Dec 22, 2022
@andre4i andre4i marked this pull request as ready for review December 22, 2022 01:13
@andre4i andre4i requested review from msfluid-bot and a team as code owners December 22, 2022 01:13
alexvy86
alexvy86 reviewed Dec 22, 2022
View reviewed changes
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

packages/runtime/container-runtime/src/opLifecycle/outbox.ts Outdated Show resolved Hide resolved
packages/test/test-service-load/src/optionsMatrix.ts Outdated Show resolved Hide resolved
@andre4i andre4i changed the title Add stress test for chunked payloads with compression - WORK IN PROGRESS Add stress test for chunked payloads with compression Dec 22, 2022
alexvy86
alexvy86 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vladsud
vladsud reviewed Jan 17, 2023
View reviewed changes
tools/pipelines/test-real-service-stress.yml
@@ -123,3 +123,45 @@ stages:
env:
fluid__test__driver__frs: $(automation-fluid-test-driver-frs-stress-test)
FLUID_TEST_LOGGER_PKG_PATH: ${{ variables.testWorkspace }}/node_modules/@ff-internal/aria-logger # Contains getTestLogger impl to inject

# stress tests large payloads odsp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we evaluate this change? It will (if I got it right) cause more runs against ODSP / SPDF, which may result in more throttling. Is it enable and see what happens? Please be prepared to back out :)

@andre4i andre4i merged commit eabe3d1 into microsoft:main Jan 31, 2023
andre4i added a commit that referenced this pull request Feb 1, 2023
@andre4i
Revert "Add stress test for chunked payloads with compression (#13431)"
ad50c8f 
This reverts commit eabe3d1.
andre4i added a commit to andre4i/FluidFramework that referenced this pull request Feb 1, 2023
@andre4i
Revert "Add stress test for chunked payloads with compression (micros…
e0efe2e 
…oft#13431)"

This reverts commit eabe3d1.
@andre4i andre4i mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvy86 alexvy86 alexvy86 approved these changes

@vladsud vladsud vladsud approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees
No one assigned
Labels
area: build Build related issues area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andre4i @msfluid-bot @alexvy86 @vladsud