Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate policy check changes through repo #10065

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Integrate policy check changes through repo #10065

merged 4 commits into from
Apr 27, 2022

Conversation

ChumpChief
Copy link
Contributor

Updates build-tool private flag check changes from #10040.

Changes include:

  • @fluid-example packages become private (aside from table-document)
  • Bubblebench moves to @fluid-example (verified with @DLehenbauer)
  • A few small package description updates to align with modern terminology

@ChumpChief ChumpChief requested review from msfluid-bot and a team as code owners April 27, 2022 05:41
@github-actions github-actions bot added area: definitions area: examples Changes that focus on our examples area: runtime Runtime related issues area: server Server related issues (routerlicious) dependencies Pull requests that update a dependency file labels Apr 27, 2022
@ChumpChief ChumpChief mentioned this pull request Apr 27, 2022
Closed
@github-actions github-actions bot added the base: main PRs targeted against main branch label Apr 27, 2022
@ChumpChief
Copy link
Contributor Author

Side benefit: This drops the npm pack stage from ~85s to ~48s, presumably due to examples not needing to publish.

@ChumpChief ChumpChief merged commit 0f8784f into microsoft:main Apr 27, 2022
@ChumpChief ChumpChief deleted the IntegratePolicyCheck branch April 27, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbutler tylerbutler tylerbutler approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

@curtisman curtisman Awaiting requested review from curtisman

@markfields markfields Awaiting requested review from markfields

Assignees
No one assigned
Labels
area: definitions area: examples Changes that focus on our examples area: runtime Runtime related issues area: server Server related issues (routerlicious) base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChumpChief @tylerbutler