Skip to content

Commit

Permalink
build(client): Update socket.io-client and remove patch (#19379)
Browse files Browse the repository at this point in the history
The patch to socket.io-client to make it compatible with node16
moduleResolution has been merged and released, so I updated the version
of socket.io-client to a version that includes the fix. Also removed the
patch.
  • Loading branch information
tylerbutler committed Jan 31, 2024
1 parent f1297f8 commit b0d55df
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 1,027 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,6 @@
},
"patchedDependencies": {
"@microsoft/api-extractor@7.39.1": "patches/@microsoft__api-extractor@7.39.1.patch",
"socket.io-client@4.7.2": "patches/socket.io-client@4.7.2.patch",
"tsc-multi@1.1.0": "patches/tsc-multi@1.1.0.patch"
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/drivers/driver-base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
"moment": "^2.21.0",
"prettier": "~3.0.3",
"rimraf": "^4.4.0",
"socket.io-client": "^4.6.1",
"socket.io-client": "^4.7.3",
"tsc-multi": "^1.1.0",
"typescript": "~5.1.6"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/drivers/local-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
"moment": "^2.21.0",
"prettier": "~3.0.3",
"rimraf": "^4.4.0",
"socket.io-client": "^4.6.1",
"socket.io-client": "^4.7.3",
"tsc-multi": "^1.1.0",
"typescript": "~5.1.6"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/drivers/odsp-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"@fluidframework/protocol-definitions": "^3.2.0-231454",
"@fluidframework/telemetry-utils": "workspace:~",
"node-fetch": "^2.6.9",
"socket.io-client": "^4.6.1",
"socket.io-client": "^4.7.3",
"uuid": "^9.0.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/drivers/routerlicious-driver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
"@fluidframework/telemetry-utils": "workspace:~",
"cross-fetch": "^3.1.5",
"json-stringify-safe": "5.0.1",
"socket.io-client": "^4.6.1",
"socket.io-client": "^4.7.3",
"url-parse": "^1.5.8",
"uuid": "^9.0.0"
},
Expand Down
9 changes: 0 additions & 9 deletions patches/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,6 @@ The files in this folder are patches for packages we depend on within the repo.

Each patch is described here, along with any relevant links to issues or PRs and any additional relevant details.

### socket.io-client

This patch updates the `exports` field in package.json to be correct for TypeScript projects using
`moduleResolution: node16`.

It applies the changes covered in this PR: https://github.com/socketio/socket.io-client/pull/1595

As soon as a version of the package is released with the changes in that PR, this patch can be removed.

### @microsoft/api-extractor

This patch adds a required fix to make it possible to validate release tag compatibility across package boundaries.
Expand Down
Loading

0 comments on commit b0d55df

Please sign in to comment.