Fixup verify quote script for load balancer #6454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtropets
commented
Aug 27, 2024
If talking to load balancer, we might retrieve node quotes for node 1, and then talk to node 2 when checking the public key. To make this work unconditionally, we now check all quotes until we find a match or report that there's no match.
maxtropets
force-pushed
the
f/fixup-verify-quote-load-balancer-case
branch
from
eec3a96
to
089def1
Compare
|
Tried manually on 3-node network. Also manually shuffled node addresses inside the script to imitate load-balancing, worked just fine. |
achamayou
approved these changes
Aug 27, 2024
maxtropets
added
auto-backport
ccf-bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
(cherry picked from commit c0178a7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If talking to load balancer, we might retrieve node quotes for node 1, and then talk to node 2 when checking the public key. To make this work unconditionally, we now check all quotes until we find a match or report that there's no match.