Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added movetoGPS #3746

Merged
merged 6 commits into from
Dec 2, 2021
Merged

Added movetoGPS #3746

merged 6 commits into from
Dec 2, 2021

Conversation

ahmed-elsaharti
Copy link
Contributor

About

Adds a movetoGPS API to let users specify a GPS position to go to rather than being limited to NED space with movement APIs when using simpleflight.

Almost an exact copy of the movetoposition call but uses the home-geopoint to calculate the NED coordinates of the GPS position provided and passes that to the move method (in NED).

Still a WIP but would love to hear any feedback

How Has This Been Tested?

Tested locally on Windows

@MinnDevelopment
Copy link
Contributor

Would it make sense to also support a function similar to moveOnPath?

@zimmy87 zimmy87 marked this pull request as ready for review December 2, 2021 08:43
@zimmy87
Copy link
Contributor

zimmy87 commented Dec 2, 2021

Thanks for the contribution @ahmed-elsaharti! Tested this locally and it works as expected for me, so I am moving ahead with merging. As for @MinnDevelopment's comment, a GPS-enabled version of moveOnPath would be great, but I think it's a little out of scope for this PR (it'd be a great idea for a separate PR).

@zimmy87 zimmy87 merged commit a7c05fc into microsoft:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants