-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observation text publisher #3034
Observation text publisher #3034
Conversation
So that it is easy to publish the text representation of the context to somewhere (e.g.: stdout)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, I've added a small remark
* | ||
* @param key key by which to remove an entry | ||
*/ | ||
public void remove(Object key) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should return the removed object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 I just moved this method, did not change the signature but we should definitely do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a pretty awesome debugging tool to me. Maybe we want to consider some kind of debug option that registers this.
@shakuzen 👍🏼 I'm going to implement this soon. |
Example output: