-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onMeterRegistrationFailed listener configuration to MeterRegistry #2068
Comments
The tag mismatch sometimes happens due to two different libraries creating the same meter name and not matching on tags; netty and httpclient I believe hit this at one time. Would a user be able to use a MeterFilter to clean up those tags if they got into that situation? Sure, the best solution is to have the libraries not step on each other, but I just wanted to think through what options would be available to users when hitting this exception. |
|
Also included here is a new method on |
cc / @izeye because I know you've been squashing all the tag problems lately (and many thanks for this)! Just want you to be aware of the different behavior. |
…me and different tags See micrometer-metricsgh-2068
This is mainly driven by the significant burden Prometheus' requirement places on everyone for the same metric name to have the same set of tags.
Previously,
PrometheusMeterRegistry
threw anIllegalArgumentException
. Now, we'll not throw an exception but instead silently continue, but inform any callbacks registered that thisMeter.Id
could not be registered.In this way, the user can do whatever they'd like with these problems, including logging or propagating a hard failure if they choose.
In theory the same mechanism could be used by any other registry implementation that has hard validation requirements like this.
See issues like #1253 for motivation.
The text was updated successfully, but these errors were encountered: