Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Shape; Horn #76

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

bendablegears
Copy link
Contributor

truncated cone test

This pull request adds a truncated-cone-with-spherical-caps Shape, to which I've given the slightly easier to type name Horn. It is much like a Cone or a Cylinder but each of the ends can have their diameter set independently using frontDiameter and rearDiameter. It should be useful in creating more organic models.

I tried to follow the architecture of similar Shapes but I'm not sure I succeeded in making it readable. I'm also not sure if my eccentricity calculations make any geometric sense but the effects ends up looking good enough.

Composite shapes use volume to find Z. Shapes with closed paths ignore doubled final point when averaging Z.
jslint doesn't complain anymore. Vector class has useful isSame function.
Actually "truncated cone with spherical caps"  but that's a mouthful.
frontDiameter and endDiameter can actually be changed, now.
@desandro
Copy link
Member

Add a 👍 reaction to this issue if you would like to see this feature added. Do not add +1 comments — They will be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants