Optional GUI/PM dependencies #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
installed only when the 'acq' flag is specified
Codecov Report
@@ Coverage Diff @@
## main #456 +/- ##
=====================================
Coverage 9.45% 9.45%
=====================================
Files 29 29
Lines 4592 4592
=====================================
Hits 434 434
Misses 4158 4158
|
|
@talonchandler @ieivanov @ziw-liu Since we are now preparing recOrder for use as image analysis library in other projects (mantis, phenosight), it makes sense that napari and pycro-manager are optional dependencies. Please review and merge soon. @ziw-liu I suggest that phenosight fetches recOrder from git repo instead of pypi while we fine tune recOrder to work well with it. cc: @Soorya19Pradeep |
mattersoflight
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PhenoSight and mantis, the pinned Qt and pycro-manager versions makes depending on recOrder difficult.
Here these dependencies are made optional through the
acqflag.