Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Menu -> Repository activity and cleanup layouts on content_main #1060

Merged
merged 2 commits into from
Feb 23, 2019

Conversation

iscle
Copy link
Contributor

@iscle iscle commented Feb 23, 2019

The repository activity works now. The problem was that Android P has new network policies and we didn't account for it.

Since Android P cleartext http trafic is not allowed by default. You can solve this by adding a flag to AndroidManifest.xml
@meefik meefik merged commit 3f6ba44 into meefik:master Feb 23, 2019
@meefik
Copy link
Owner

meefik commented Feb 23, 2019

It works in Android 9 but not working in Android 4..

@iscle
Copy link
Contributor Author

iscle commented Feb 23, 2019

Oh man, when we fix it in one version it breaks the other one hahaha let me check again!

@iscle
Copy link
Contributor Author

iscle commented Feb 23, 2019

It works in Android 9 but not working in Android 4..

Can you specify the version? It crashed once on API 19 but it works after the second attempt. I couldn't catch the logcat.

@meefik
Copy link
Owner

meefik commented Feb 23, 2019

My Android 4.4.2

@iscle
Copy link
Contributor Author

iscle commented Feb 23, 2019

My Android 4.4.2

02-23 21:03:21.146 2084-2123/? W/System.err: java.io.FileNotFoundException: env 02-23 21:03:21.146 2084-2123/? W/System.err: at android.content.res.AssetManager.openAsset(Native Method) 02-23 21:03:21.146 2084-2123/? W/System.err: at android.content.res.AssetManager.open(AssetManager.java:316) 02-23 21:03:21.146 2084-2123/? W/System.err: at android.content.res.AssetManager.open(AssetManager.java:290) 02-23 21:03:21.146 2084-2123/? W/System.err: at ru.meefik.linuxdeploy.EnvUtils.extractFile(EnvUtils.java:53) 02-23 21:03:21.146 2084-2123/? W/System.err: at ru.meefik.linuxdeploy.EnvUtils.extractDir(EnvUtils.java:87) 02-23 21:03:21.156 2084-2123/? W/System.err: at ru.meefik.linuxdeploy.EnvUtils.updateEnv(EnvUtils.java:318) 02-23 21:03:21.156 2084-2123/? W/System.err: at ru.meefik.linuxdeploy.UpdateEnvTask.doInBackground(UpdateEnvTask.java:32) 02-23 21:03:21.156 2084-2084/? D/EGL_emulation: eglMakeCurrent: 0xb9829110: ver 2 0 02-23 21:03:21.156 2084-2123/? W/System.err: at ru.meefik.linuxdeploy.UpdateEnvTask.doInBackground(UpdateEnvTask.java:10) 02-23 21:03:21.156 2084-2123/? W/System.err: at android.os.AsyncTask$2.call(AsyncTask.java:288) 02-23 21:03:21.156 2084-2123/? W/System.err: at java.util.concurrent.FutureTask.run(FutureTask.java:237) 02-23 21:03:21.156 2084-2123/? W/System.err: at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231) 02-23 21:03:21.156 2084-2123/? W/System.err: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) 02-23 21:03:21.156 2084-2123/? W/System.err: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) 02-23 21:03:21.166 2084-2123/? W/System.err: at java.lang.Thread.run(Thread.java:841)

The repository menu does work for me, however what doesn't work is everything else. It looks like the env folder is not being found. Should this folder be copied automatically when installing the app or later when it's opened?

@meefik
Copy link
Owner

meefik commented Feb 23, 2019

After opened

@iscle
Copy link
Contributor Author

iscle commented Feb 23, 2019

This is very strange, I don't see why it doesn't work now if it was working before... On Pie the same error is thrown... But it shouldn't be too difficult to solve.

Do you mind waiting a few hours until I have time to solve it?

@meefik
Copy link
Owner

meefik commented Feb 23, 2019

Do you mind waiting a few hours until I have time to solve it?

Yes, of course :)

@iscle
Copy link
Contributor Author

iscle commented Feb 24, 2019

I think it's a git issue. The submodule pointing to linuxdeploy-cli is not downloading here:

https://github.com/meefik/linuxdeploy/tree/master/app/src/main/assets

Maybe you will need to re-create it.

Edit: I've just tried manually adding the latest env folder from the repository and it works, so yes, a git issue. I don't know how to solve, not an expert working with git :(
I saw you updated the linuxdeploy-cli repository and that might have confused git into not downloading that part.

Edit 2: I think i've solved it. I updated the subrepository (or whatever it's called) to the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants