Keep the GIF properties dictionary alive until we're done #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GIF properties dictionary is, as far as we know, only retained by the image source properties dictionary we got it from. So in order to ensure that the GIF properties dictionary sticks around until we're done with it, we must not release the image source properties dictionary until we no longer need the GIF properties dictionary or any objects obtained from it. It seems that this is not causing any observable issues, which suggests that there must be something else retaining the image source properties or GIF properties dictionaries (e.g., the image source itself). But that could well change in a future release of OS X.
|
Good work. Thanks for the patch. |
mayoff
added a commit
that referenced
this pull request
Oct 29, 2013
Keep the GIF properties dictionary alive until we're done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GIF properties dictionary is, as far as we know, only retained by the image source properties dictionary we got it from. So in order to ensure that the GIF properties dictionary sticks around until we're done with it, we must not release the image source properties dictionary until we no longer need the GIF properties dictionary or any objects obtained from it.
It seems that this is not causing any observable issues, which suggests that there must be something else retaining the image source properties or GIF properties dictionaries (e.g., the image source itself). But that could well change in a future release of OS X.