Setuptools #402
Setuptools #402
Conversation
setup.py
Outdated
| from distutils.dist import Distribution | ||
| from distutils.util import convert_path | ||
| from distutils import ccompiler, sysconfig | ||
| from setuptools.dist import Distribution |
setup.py
Outdated
| req | ||
| for req in content.split("\n") | ||
| if req != '' and not req.startswith('#') | ||
| ] |
There was a problem hiding this comment.
style quibble: I don't like the closing paren being indented that way. I would probably put the read functionality inside the get_install_requirements function, since it isn't used anywhere else, and then format the return as
return [req for req in content.split("\n")
if req and not req.startswith('#')]
|
could you rebase this onto master to make it easier to see the remaining differences? |
|
This is ready for another round of reviews. |
|
Is it basically assumed now that people have setuptools installed? I guess it is pretty much safe because matplotlib has been requiring setuptools for awhile now, right? |
Yep. |
# Do not merge this before #400 and #401... and simplify how we deal with the requirements in
setup.py.