Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4478

Closed
wants to merge 1 commit into from

Conversation

amir-al-mohamad
Copy link

@amir-al-mohamad amir-al-mohamad commented Sep 21, 2024

  • DEMO LINK

  • TEST REPORT LINK

  • Icon implemented using background-image CSS property

  • Inputs are written inside of 'form' tag with correctly passed attributes

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on your Pull Request! 🎉 All key functionalities seem to be in place and there are no critical issues affecting the code. Just a few minor points to consider for future projects: keep an eye on consistent margins to avoid layout issues, use meaningful class names that describe content or function, and maintain proper attribute formatting and indentation for better readability. Keep coding and improving! 👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html Show resolved Hide resolved
src/index.html Show resolved Hide resolved
src/index.html Show resolved Hide resolved
src/index.html Show resolved Hide resolved
src/style.css Show resolved Hide resolved
src/style.css Show resolved Hide resolved
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants