improve errors #4567

modship · 2023-11-28T13:36:00Z

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

massa-execution-worker/src/context.rs

Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>

damip

Good job !

* Update version & CI * Test/array indexing checkup 1 (#4560) * Update ci.yml * Feature/feature/versioning ser der harden 2 (#4554) * Add some unit tests for versioning deserialization to the limits * Clippy pass * Better error message * Minor fixes * Excluded -> Included --------- Co-authored-by: sydhds <sydhds@gmail.com> * Add versioninig key & value checks (#4552) * Add versioninig key & value checks * Improve error message when no prefix --------- Co-authored-by: sydhds <sydhds@gmail.com> * Update CI, Version and genesis timestamp * Add array indexing listing tool * Remove array indexing in denunciation code * Remove more array indexing * Add more exclude patterns * Use nom take --------- Co-authored-by: sydhds <sydhds@gmail.com> * Fails in send_operations if get_gas_usage() > max_gas_per_block Returning a distinct error message for ExecuteSC and CallSC operations. Signed-off-by: Jean-François <jfm@laposte.net> * coins spending tests (#4532) * Buildnet WIP * Mock Final State/Improve tests execution (#4512) * Use a controller for final state to be able to mock it * Fix all formatting issues. * Use more mocks in execution tests * Fix test nested call usage * improve some tests execution * Fix tests async message and compact the test of executed * Fix more execution tests * Fix more tests. * Update more tests * Finish fixing all executions tests. * Improve naming * add more comment * Fix comment * update test to check spend coins with readonly * add coins * check coins on rollbuy * clippy * update roll_buy * delete helloworld wasm * update test_readonly_execution * fix tests merge * fix test test_readonly_execution * Update ci.yml * Feature/feature/versioning ser der harden 2 (#4554) * Add some unit tests for versioning deserialization to the limits * Clippy pass * Better error message * Minor fixes * Excluded -> Included --------- Co-authored-by: sydhds <sydhds@gmail.com> * Add versioninig key & value checks (#4552) * Add versioninig key & value checks * Improve error message when no prefix --------- Co-authored-by: sydhds <sydhds@gmail.com> * Update CI, Version and genesis timestamp * add test for cancel_async_msg * clippy * cancel async msg check refound sender --------- Co-authored-by: Leo-Besancon <lb@massa.net> Co-authored-by: AurelienFT <32803821+AurelienFT@users.noreply.github.com> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> * improve errors (#4567) * tech(async_msg) : check if the target address exist * tech(call_sc) : add check target address to call_sc_op * check target sc address on init_call * check target address in read only call * fix unit tests * remove dbg macro * Update massa-execution-worker/src/context.rs Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> --------- Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> * Fix tests (#4568) * Fix CI WIP (#4569) * Fix ws_disabled() test on windows * fix bootstrap server port * Fix CI local Leo * Update scenarios_mandatories.rs * Add CI profile argument to nextest --------- Co-authored-by: modship <yeskinokay@gmail.com> * Fix test + Update lcov.info * Add codecov.yml * fix internal error serde (#4570) * Release prebuilt profile (#4572) * codegen-units set to 1 for prebuilt binaries * Update toolchain version in CI & CD * Update CI & Genesis --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Jean-François <jfm@laposte.net> Co-authored-by: Modship <yeskinokay@gmail.com> Co-authored-by: AurelienFT <32803821+AurelienFT@users.noreply.github.com> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>

tech(async_msg) : check if the target address exist

df49ae0

modship marked this pull request as draft November 28, 2023 13:36

modship linked an issue Nov 28, 2023 that may be closed by this pull request

improve error message #4551

Closed

modship added 3 commits November 28, 2023 14:51

tech(call_sc) : add check target address to call_sc_op

327355d

check target sc address on init_call

e492ce9

check target address in read only call

50cd497

modship marked this pull request as ready for review November 28, 2023 14:21

modship added 2 commits November 28, 2023 16:11

fix unit tests

58f0dc6

remove dbg macro

945954d

modship requested review from damip and Leo-Besancon November 28, 2023 15:20

damip reviewed Nov 28, 2023

View reviewed changes

massa-execution-worker/src/context.rs Outdated Show resolved Hide resolved

Update massa-execution-worker/src/context.rs

a4cc002

Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>

damip approved these changes Nov 28, 2023

View reviewed changes

damip merged commit 20f77e6 into pre_mainnet_wip Nov 28, 2023
9 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve errors #4567

improve errors #4567

modship commented Nov 28, 2023

damip left a comment

improve errors #4567

improve errors #4567

Conversation

modship commented Nov 28, 2023

damip left a comment

Choose a reason for hiding this comment