Cross os checksums #4564
Merged
Cross os checksums #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update ci.yml * Feature/feature/versioning ser der harden 2 (#4554) * Add some unit tests for versioning deserialization to the limits * Clippy pass * Better error message * Minor fixes * Excluded -> Included --------- Co-authored-by: sydhds <sydhds@gmail.com> * Add versioninig key & value checks (#4552) * Add versioninig key & value checks * Improve error message when no prefix --------- Co-authored-by: sydhds <sydhds@gmail.com> * Update CI, Version and genesis timestamp * Add array indexing listing tool * Remove array indexing in denunciation code * Remove more array indexing * Add more exclude patterns * Use nom take --------- Co-authored-by: sydhds <sydhds@gmail.com>
Leo-Besancon
previously approved these changes
Nov 28, 2023
aoudiamoncef
force-pushed
the
hotfix/checksums-cross-os
branch
from
7c4e0e9
to
8dbc28f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4564 +/- ##
=======================================
Coverage 72.55% 72.55%
=======================================
Files 288 288
Lines 50874 50874
=======================================
Hits 36910 36910
Misses 13964 13964 ☔ View full report in Codecov by Sentry. |
Leo-Besancon
approved these changes
Nov 28, 2023
Leo-Besancon
added a commit
that referenced
this pull request
Nov 30, 2023
* Update version & CI * Test/array indexing checkup 1 (#4560) * Update ci.yml * Feature/feature/versioning ser der harden 2 (#4554) * Add some unit tests for versioning deserialization to the limits * Clippy pass * Better error message * Minor fixes * Excluded -> Included --------- Co-authored-by: sydhds <sydhds@gmail.com> * Add versioninig key & value checks (#4552) * Add versioninig key & value checks * Improve error message when no prefix --------- Co-authored-by: sydhds <sydhds@gmail.com> * Update CI, Version and genesis timestamp * Add array indexing listing tool * Remove array indexing in denunciation code * Remove more array indexing * Add more exclude patterns * Use nom take --------- Co-authored-by: sydhds <sydhds@gmail.com> * fix: cross os checksums * Revert "Test/array indexing checkup 1 (#4560)" This reverts commit 7efca19. * Revert "Update version & CI" This reverts commit 77f33a0. --------- Co-authored-by: Leo-Besancon <lb@massa.net> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resync_checkflag