Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing query filters #4368

Merged
merged 6 commits into from
Sep 4, 2023
Merged

Add missing query filters #4368

merged 6 commits into from
Sep 4, 2023

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Aug 23, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification
  • Refactor SearchBlocks
  • Fix SlotRange Filters in NewXXX queries
  • Refactor SearchEndorsements
  • Refactor SearchOperations
  • Merge all dependencies PRs

Resolves massalabs/massa-proto#52 massalabs/massa-proto#49

@aoudiamoncef aoudiamoncef marked this pull request as ready for review August 28, 2023 17:03
@aoudiamoncef aoudiamoncef force-pushed the feature/add-filters branch 2 times, most recently from b530fef to c508d56 Compare September 1, 2023 09:33
fix: new ops

refactor: add filter to new endorsements

refactor: add filter to new blocks

refactor: add limits + imprvs

refactor: add filled blocks filters

refactor: add missing filters + change algo

build: upgrade to latest proto

refactor: remove SecureShare from gRPC

fix: slot range in NewBlocks

fix: GetSelectorDraws

feat: add limit to received filters

ffix: add uniqueness to SlotDraws

new blocks option

refactor: update new filters

fix: add hashset for filters

fix: search operation

fix: search op

refactor: add new slot exec get_filter

feat: add new_slot_execution_outputs filter map

refactor: add limit to slot range search

refactor: upgrade SearchBlocks

feat: add config for slot range length

refactor: add SlotRange intersection
@aoudiamoncef aoudiamoncef changed the base branch from main to testnet_26 September 1, 2023 10:28
massa-proto-rs = {git = "https://github.com/massalabs/massa-proto-rs", "rev" = "c7a29753d7d31864779db01e8260a8bf0748e10c"}
massa-sc-runtime = {git = "https://github.com/massalabs/massa-sc-runtime", "branch" = "main"}
massa-proto-rs = {git = "https://github.com/massalabs/massa-proto-rs", "branch" = "develop"}
massa-sc-runtime = {git = "https://github.com/massalabs/massa-sc-runtime", "branch" = "develop"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to target develop ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge and update massa-proto-rs, massa-sc-runtime before

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to update here :p

massa-grpc/src/public.rs Outdated Show resolved Hide resolved
massa-grpc/src/public.rs Outdated Show resolved Hide resolved
@modship
Copy link
Member

modship commented Sep 1, 2023

maybe SlotRange should use Bound<Slot> https://doc.rust-lang.org/stable/std/ops/enum.Bound.html#

massa-grpc/src/lib.rs Outdated Show resolved Hide resolved
massa-grpc/src/lib.rs Outdated Show resolved Hide resolved
@aoudiamoncef aoudiamoncef merged commit bf3ae0a into testnet_26 Sep 4, 2023
10 checks passed
@aoudiamoncef aoudiamoncef deleted the feature/add-filters branch September 4, 2023 09:06
aoudiamoncef added a commit that referenced this pull request Sep 4, 2023
@aoudiamoncef aoudiamoncef restored the feature/add-filters branch September 4, 2023 09:10
@AurelienFT AurelienFT deleted the feature/add-filters branch October 23, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation submission is impractical
2 participants