Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataFrame getitem when exists duplicate columns #2581

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

hekaisheng
Copy link
Contributor

What do these changes do?

This PR fixes the TypeError when select data from a DataFrame that has duplicate columns/

Related issue number

Fixes #2578

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@hekaisheng hekaisheng added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Nov 16, 2021
@hekaisheng hekaisheng added this to the v0.9.0a1 milestone Nov 16, 2021
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 9f6b857 into mars-project:master Nov 17, 2021
@hekaisheng hekaisheng deleted the bugfix/df-getitem branch November 17, 2021 03:50
hekaisheng added a commit to hekaisheng/mars that referenced this pull request Nov 17, 2021
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Dec 7, 2021
chaokunyang pushed a commit to chaokunyang/mars that referenced this pull request May 31, 2022
# Conflicts:
#	mars/dataframe/indexing/getitem.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DataFrame getitem raised TypeError
3 participants