Implement DataFrame nunique #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekaisheng
added
type: feature
hekaisheng
force-pushed
the
feature/df-unique
branch
2 times, most recently
from
f11595f
to
dc496be
Compare
|
Does this PR solve #1124 or not? At a glance, docs are absent. |
Codecov Report
@@ Coverage Diff @@
## master #1137 +/- ##
=========================================
Coverage ? 92.97%
=========================================
Files ? 642
Lines ? 49944
Branches ? 7416
=========================================
Hits ? 46437
Misses ? 2309
Partials ? 1198
Continue to review full report at Codecov.
|
hekaisheng
force-pushed
the
feature/df-unique
branch
from
627b44a
to
93e7c70
Compare
qinxuye
reviewed
Apr 8, 2020
hekaisheng
force-pushed
the
feature/df-unique
branch
from
bd3e22c
to
4432777
Compare
hekaisheng
added a commit
to hekaisheng/mars
that referenced
this pull request
Apr 20, 2020
(cherry picked from commit b9f8434)
hekaisheng
added a commit
to hekaisheng/mars
that referenced
this pull request
Apr 20, 2020
(cherry picked from commit b9f8434)
qinxuye
added
backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR implements df.unique, it's now a simple way that record all unique values and count them at the aggregation stage, it should be optimized if the amount of unique values are too large.
Related issue number
Resolves #1124 .