Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for isna, notna and __dir__ #1125

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Add support for isna, notna and __dir__ #1125

merged 3 commits into from
Mar 31, 2020

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Mar 31, 2020

What do these changes do?

Support DataFrame.__dir__, isna() and notna().

Related issue number

Fixes #1111
Fixes #1117

@wjsi wjsi added type: feature New feature mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Mar 31, 2020
@wjsi wjsi added this to the v0.4.0rc1 milestone Mar 31, 2020
qinxuye
qinxuye approved these changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 4af83ec into mars-project:master Mar 31, 2020
@wjsi wjsi deleted the feature/check_na branch March 31, 2020 09:03
wjsi added a commit to wjsi/mars that referenced this pull request Mar 31, 2020
@wjsi
Add support for isna, notna and __dir__ (mars-project#1125)
bf88013
@wjsi wjsi mentioned this pull request Mar 31, 2020
Merged
hekaisheng pushed a commit that referenced this pull request Apr 1, 2020
@wjsi
[BACKPORT] Add support for isna, notna and __dir__ (#1125) (#1126)
02a0dc3 
* Add support for isna, notna and __dir__ (#1125)

* Patch for Python 2.7
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: dataframe type: feature New feature
Projects
None yet
Milestone
v0.4.0rc1
Development

Successfully merging this pull request may close these issues.

Add md.isna support Add __dir__ for Mars DataFrame
2 participants
@wjsi @qinxuye