Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support calling df.agg() with lists or dicts for transform #1093

Merged
merged 5 commits into from
Mar 26, 2020

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Mar 23, 2020

What do these changes do?

Add support for expressions like df.agg(['cumsum', 'cummax']). This is implemented via extending df.transform() with a special option indicating the caller is agg.

Related issue number

Fixes #1084

@wjsi wjsi added this to the v0.4.0b2 milestone Mar 23, 2020
@wjsi wjsi changed the title Support calling df.agg() with lists or dicts Support calling df.agg() with lists or dicts for transform Mar 24, 2020
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit b210b0d into mars-project:master Mar 26, 2020
@wjsi wjsi deleted the feature/full_agg branch March 26, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support calling df.transform() with lists or dicts
2 participants